Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1.3] FIX: Query error when disabling all credentials #23

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

Bubka
Copy link
Contributor

@Bubka Bubka commented Nov 11, 2022

Description

This fix removes references to an unknown column that throw an exception during credentials disabling.

@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 82.34% // Head: 82.34% // No change to project coverage 👍

Coverage data is based on head (ef3ad38) compared to base (af04066).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##                1.x      #23   +/-   ##
=========================================
  Coverage     82.34%   82.34%           
  Complexity      367      367           
=========================================
  Files            61       61           
  Lines           929      929           
=========================================
  Hits            765      765           
  Misses          164      164           
Impacted Files Coverage Δ
src/Models/WebAuthnCredential.php 100.00% <ø> (ø)
src/WebAuthnAuthentication.php 25.92% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DarkGhostHunter
Copy link
Contributor

Thanks. I'll add a test for that so it doesn't break in the future.

@DarkGhostHunter DarkGhostHunter merged commit afa5b62 into Laragear:1.x Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants